Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use cached calibration result for faster bootup
......................................................................
Patch Set 29:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr...
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr...
PS12, Line 911: dramc_dbg("[bypass Gating]\n");
@huayang Why adding "[" and "]" in this debug message?
I think that's okay for debug messages. After all, this file already contains this kinds of logs.
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/in...
File src/soc/mediatek/mt8183/include/soc/emi.h:
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/in...
PS12, Line 26: sdram_params
I think a better style is to isolate the part of serialization, for example […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ef4265dd369a1c276bb02294696556df927e7bc
Gerrit-Change-Number: 35164
Gerrit-PatchSet: 29
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 03:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment