3 May
2019
3 May
'19
7:52 a.m.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32542 )
Change subject: mb/siemens/mc_apl2: Limit SD-Card speed to DDR50 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32542/2/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c:
https://review.coreboot.org/#/c/32542/2/src/mainboard/siemens/mc_apl1/varian... PS2, Line 49: pci_read_config32(dev
Use find_resource(dev) and res2mmio
I had a look into find_resource(dev) and res2mmio. At the first glance it looked weird...but then, looking deeper, it turned out to be a nice way to do it. Will change.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5fed5fb70b027de34170b49620927614a00fb7a
Gerrit-Change-Number: 32542
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 03 May 2019 05:52:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment