Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 26:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... PS25, Line 157: malloc
a local variable is sufficient here
Done
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... PS25, Line 245: malloc
a local variable is sufficient here.
Done
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/ea... PS25, Line 249: mux_data.usb
good point here... […]
Done
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/fs... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/fs... PS25, Line 376: Calling
THe whole "calling ... […]
will remove and update
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/in... PS25, Line 133: pmc
PMC
Done