Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27068 )
Change subject: gma config: Make Config.CPU and Config.CPU_Var variable
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/27068/6/common/hw-gfx-gma-config.ads.templat...
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/#/c/27068/6/common/hw-gfx-gma-config.ads.templat...
PS6, Line 69: ,
It's an ugly trick, really: Ada doesn't allow a dangling comma […]
or patch set 7... but that moves the readability issue to the makefile ;)
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/27068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: If409b5afbd975f3a42e28ff191a092f89ece5ae2
Gerrit-Change-Number: 27068
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Apr 2019 22:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment