Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36856 )
Change subject: soc/intel/skylake/acpi/dptf: Disable DTRP when no DPTF_TSRX_SENSOR_ID is defined ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36856/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36856/2//COMMIT_MSG@10 PS2, Line 10: Only the DTRP method when at least one sensor is enabled. "Only add"?
https://review.coreboot.org/c/coreboot/+/36856/2/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/dptf/thermal.asl:
https://review.coreboot.org/c/coreboot/+/36856/2/src/soc/intel/skylake/acpi/... PS2, Line 78: #ifdef DPTF_TSR0_SENSOR_ID | DPTF_TSR1_SENSOR_ID | DPTF_TSR2_SENSOR_ID first time I see this syntax. For more complex preprocessor statements we usually use #if defined(FOO) || defined(BAR)