[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70222 )

Change subject: soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume
......................................................................

soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume

This patch skips sending CONN IPC command to PMC if system is resuming
from S3.

Sending CONN IPC command as part of `tcss_configure_dp_mode()` function
results into ERROR while system is resuming from S3.

Without this patch:
[ERROR]  pmc_send_ipc_cmd status: fatal
[ERROR]  Port 1 connect request failed
[SPEW ]  [TCSS] TcssInit() - End

With this patch:

No error seen during S3 resume.

Signed-off-by: Subrata Banik 
Change-Id: I1dab7dc8b4ad76ca0c9630456803c1b9a320fe40
---
M src/soc/intel/common/block/tcss/tcss.c
1 file changed, 26 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/70222/1

diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c
index b4a5a0e..5896b93 100644
--- a/src/soc/intel/common/block/tcss/tcss.c
+++ b/src/soc/intel/common/block/tcss/tcss.c
@@ -415,7 +415,7 @@
    if (tcss_ops.configure_aux_bias_pads)
    	tcss_ops.configure_aux_bias_pads(aux_bias_pads);

-	if (CONFIG(ENABLE_TCSS_DISPLAY_DETECTION))
+	if (CONFIG(ENABLE_TCSS_DISPLAY_DETECTION) && !platform_is_resuming())
    	tcss_configure_dp_mode(port_map, num_ports);
 }