21 Apr
2023
21 Apr
'23
2:19 a.m.
Attention is currently required from: Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74500 )
Change subject: arch/arm64: Add aarch64 target linker arguments ......................................................................
Patch Set 2:
(2 comments)
File src/arch/arm64/armv8/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74500/comment/12aa49f3_812c4604 PS2, Line 29: ifneq ($(CONFIG_COMPILER_GCC),y) Why check for !GCC instead of checking for LLVM_CLANG?
https://review.coreboot.org/c/coreboot/+/74500/comment/ae61e843_2366fe96 PS2, Line 35: rmodule_arm-ld-ccopts += -target aarch64-eabi Wouldn't it make more sense to do this in xcompile anyway?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ee4c0c34e2aa52e4f6c72338880a5cf9cc7009b
Gerrit-Change-Number: 74500
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 21 Apr 2023 00:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment