Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44512 )
Change subject: soc/intel/common: Call pci_dev_enable_bus_master() from .final ops
......................................................................
Patch Set 2:
Patch Set 1:
Please give a reason why devices should behave as a bus master. The PCI_COMMAND_MASTER has been removed on nearly all devices as it doesn't seem necessary. To make sure it's not removed again, please give some details what doesn't work.
Thanks Patrick, added section in commit msg itself
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife65f6029d2f966e321f616e85f59f4c37c42145
Gerrit-Change-Number: 44512
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 17 Aug 2020 07:49:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment