Attention is currently required from: Andrey Petrov, Kapil Porwal, Ronak Kanabar, Tarun Tuli.
Hello Andrey Petrov, Kapil Porwal, Ronak Kanabar, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75920?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+2 by Tarun Tuli, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: driver/intel/fsp2_0: Add support to store MRC cache using MRC version ......................................................................
driver/intel/fsp2_0: Add support to store MRC cache using MRC version
This patch uses the "generic" variable name as "version" while storing the MRC cache data instead referring to the FSP-M version or MRC version. Hence, updated all the instances of `fsp_version/fspm_version` with `version`.
The prior code changes introduces the new option to the MRC cache version that allows SoC users to store the MRC cache version either relying on the FSP-M version or the MRC version.
- MRC_CACHE_USING_FSP_VERSION: Platforms prior to Meteor Lake are expected to use FSP-M for storing the MRC cache version. - MRC_CACHE_USING_MRC_VERSION: Platforms starting with Meteor Lake use the new option that relies on the MRC version.
Additionally, added the helper function `fsp_mrc_version()` and corresponding header file to read the MRC version from the FSP binary.
BUG=b:261689642 TEST=Able to build and boot google/rex and google/omnigul.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ia8af53aed674ad4a3b426264706264df91d9c6b0 --- M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/intel/fsp2_0/save_mrc_data.c 3 files changed, 51 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/75920/2