[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm: Define single smm_subregion()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34776 )

Change subject: cpu/x86/smm: Define single smm_subregion()
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34776/4/src/cpu/x86/smm/tseg_region... 
File src/cpu/x86/smm/tseg_region.c:

https://review.coreboot.org/c/coreboot/+/34776/4/src/cpu/x86/smm/tseg_region... 
PS4, Line 63: 	case SMM_SUBREGION_IED:
> It's a matter of exposing implementation details into common x86 api. […]

Looking further to CB:34792 I think this enumeration needs to go to platform specifics. Then again I don't have a case other than IED to deal with now.

Not like I would need or want to bring the (currently 8 copies) of struct ied_header in cpu/x86. I don't yet have a clear vision what is the best way to solve the different variants of IED initialisations.