8 Jul
2019
8 Jul
'19
10:43 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31425 )
Change subject: qemu-q35: die if started on wrong machine ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31425/3/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/bootblock.c:
https://review.coreboot.org/c/coreboot/+/31425/3/src/mainboard/emulation/qem... PS3, Line 46: (pci_read_config32(PCI_DEV(0, 0, 0), D0F0_PCIEXBAR_LO) !=
The reason this works is it doesn't use pci_io_read. […]
Ah. I thought QEMU would not implement that register PCIEXBAR at all if it will not do MCFG.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1b24176de971c5f827091bc5bc1bac8426f3f6
Gerrit-Change-Number: 31425
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 08 Jul 2019 08:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment