Attention is currently required from: Bora Guvendik, Jeremy Compostella.
Wonkyu Kim has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/87032?usp=email )
Change subject: vc/google/chromeos: Add TPM_GOOGLE config check for logo selection ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87032/comment/bf6c101b_3b930f7c?usp... : PS1, Line 10: configuration within the bmp_logo_filename function.
The most important part of a commit message is to explain *why* you're doing something, not just wha […]
The purpose of the change is for removing Google TPM dependencies in bmp_logo_filename function. I think it's better not have the dependency in the function. And we can't update chromeos_device_branded_plus_hard or chromeos_device_branded_plus_soft function as they're not even compiled like below. ramstage-$(CONFIG_TPM_GOOGLE) += tpm_factory_config.c
If we don't want to change this function, we need to add dummy functions under mainboard folder in case we don't use GOOGLE_TPM.