Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38446 )
Change subject: mb/lenovo/x201: Add support for undock button on X200 ultrabase ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG@7 PS2, Line 7: mb/lenovo/x201: Add support for undock button on X200 ultrabase
mb/lenovo/x201: Support undock button on X200 ultrabase
Why? The current commit summary is using a correct tense. Is it that the summary is too long?
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG@10 PS2, Line 10: smihandler.c already supported it.
One line please. Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG@11 PS2, Line 11:
Please add the problem description. I have no idea, but something like: […]
Done, with a few remarks
https://review.coreboot.org/c/coreboot/+/38446/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38446/3//COMMIT_MSG@12 PS3, Line 12: Currently, when pressing the undock button in Linux nothing happens, : and the device cannot be safely undocked. The only method to safely : undock device is to press key combination Fn+F9. Now, pressing the : button, the green LED lights up, and the device can be removed. There's a few missing words:
undock *the* device press *the* key combination Now, *when* pressing the
I guess this is because they aren't used in your native language? In any case, adding them would make the lines a biiit too long. My OCD decided to reword this paragraph so that it fits in three lines:
On Linux, pressing the undock button does nothing, so the only safe way to undock is to press Fn+F9. With this patch, when the undock button is pressed, the green LED lights up, and undocking is safe.