Weiyi Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34777 )
Change subject: mediatek/mt8183: postpone dcxo low power mode setting
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34777/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34777/1//COMMIT_MSG@11
PS1, Line 11: We should not disable XO_CEL and block the bblpm request when MD is still ON.
nit: I have no idea what this means. What is "MD"? Please be a little more elaborate.
Done, modify it in commit message, MD => modem
https://review.coreboot.org/c/coreboot/+/34777/1/src/soc/mediatek/mt8183/inc...
File src/soc/mediatek/mt8183/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/34777/1/src/soc/mediatek/mt8183/inc...
PS1, Line 222: void dcxo_disable_unused(void);
nit: external functions should be better namespaced, e.g. […]
Done, add more description about unused stuff in commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I047ebed615e874977ca211aafd52b5551c71b764
Gerrit-Change-Number: 34777
Gerrit-PatchSet: 2
Gerrit-Owner: Weiyi Lu
weiyi.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-CC: Yanjie Jiang
yanjie.jiang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 04 Sep 2019 09:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment