Attention is currently required from: Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48383 )
Change subject: mb/fujitsu/d3410-b1: Add new mainboard ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/fujitsu/d3410-b1/Kconfig:
https://review.coreboot.org/c/coreboot/+/48383/comment/d0980ff2_941ca577 PS5, Line 34: config USE_LEGACY_8254_TIMER what for?
File src/mainboard/fujitsu/d3410-b1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48383/comment/4f527f02_e06a282f PS5, Line 77: register "SataTestMode" = "1 this is not something that should be merged
https://review.coreboot.org/c/coreboot/+/48383/comment/4a7cee1e_2d85babc PS5, Line 126: irq 0x70 = 1 : irq 0x72 = 12 why mixing hex with decimal?
https://review.coreboot.org/c/coreboot/+/48383/comment/fda2f084_a93e4b87 PS5, Line 163: io 0x62 = 0 : irq 0x70 = 0 : why mixing hex with decimal?