Attention is currently required from: Kangheui Won, Reka Norman, Paul Menzel, Julius Werner, Angel Pons, Arthur Heymans, Andrey Petrov.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67669 )
Change subject: drivers/intel/fsp2_0: Update MRC cache in ramstage
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67669/comment/d2e502da_b94d2129
PS1, Line 18:
Creating a whole new CBMEM tag just for that is a bit annoying, it would be great if we could find a […]
The FSP reserved data contains the HOBs, among other things, so it should still be there in ramstage, it just needs to be extracted.
Patchset:
PS1:
Hmm, that's a very good point, thanks. […]
I think you've made an excellent point about the complexity of this situation, and whether it is worth handling so many different flows. I think you've convinced me to go ahead and let's go with one flow (nissa flow). Please test it on ADL-P, ADL-N and TGL if possible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6aa2dee83a3ab8913830746593935d36a034b8d
Gerrit-Change-Number: 67669
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 20 Sep 2022 21:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment