Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32414 )
Change subject: arch/x86: Add option for using a custom assembly_entry
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32414/7/src/arch/x86/memlayout.ld
File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/32414/7/src/arch/x86/memlayout.ld@3...
PS7, Line 38: #include "car.ld"
As noted earlier, I would rather see all references to CAR removed early on. And if your verstage/vboot shall not run on x86 many of the sections do not need to be defined. The file is also the reason for keeping ill-named DCACHE_RAM_xx around.
I am leaving it to someone else to evaluate if this is clean enough for initial support. I would rather arrange it with preprocessor to replace every occurence of car.ld in this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I678b1f74546ea30abcc655a0daed795d6cfa0034
Gerrit-Change-Number: 32414
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 26 Jul 2019 04:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment