Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75379 )
Change subject: nb/intel/gm45/gma: Fix debug note about missing panel data ......................................................................
nb/intel/gm45/gma: Fix debug note about missing panel data
Reformat the string, fix whitespace, add single-quote before genitive `s`, and correct the GPU tool name `intel_reg`.
Change-Id: I277603063806927837867a454ae0875578228109 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/75379 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/northbridge/intel/gm45/gma.c 1 file changed, 22 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Felix Singer: Looks good to me, approved
diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 0986ad5..c53e93c 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -115,12 +115,11 @@ }
if (i == blc_array_len) - printk(BIOS_NOTICE, "Your panels EDID `%s` wasn't found in the" - "lookup table.\n You may have issues with your panels" - "backlight.\n If you want to help improving coreboot" - "please report: this EDID string\n and the result" - "of `intel_read read BLC_PWM_CTL`" - "(from intel-gpu-tools)\n while running vendor BIOS\n", + printk(BIOS_NOTICE, "Your panel's EDID `%s` wasn't found in the lookup table.\n" + "You may have issues with your panel's backlight.\n" + "If you want to help improving coreboot please report: this EDID string\n" + "and the result of `intel_reg read BLC_PWM_CTL` (from intel-gpu-tools)\n" + "while running vendor BIOS\n", edid_ascii_string);
return blc_pwm_freq;