Attention is currently required from: Werner Zeh.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69544 )
Change subject: mb/siemens/mc_ehl2/devicetree.cb: Use RV3028 bus_speed instead of dummy i2c device ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163616): https://review.coreboot.org/c/coreboot/+/69544/comment/36466f13_dc4fd5ac PS1, Line 9: Instead of creating a dummy I2C device in order to force Linux to decrease the Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163616): https://review.coreboot.org/c/coreboot/+/69544/comment/9b68e439_e6b943a1 PS1, Line 10: I2C bus speed, use the own 'bus_speed' field of RV3028 device config structure. Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163616): https://review.coreboot.org/c/coreboot/+/69544/comment/9f45c09e_5c85e765 PS1, Line 12: Linux should always set the bus speed to the speed of the slowest device sitting Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163616): https://review.coreboot.org/c/coreboot/+/69544/comment/8e2d471a_b5838274 PS1, Line 16: TEST=See if the RV3028 RTC is visible and working (date/time can be set/read) in Possible unwrapped commit description (prefer a maximum 72 chars per line)