[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Matt DeVillier.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48787 )

Change subject: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY
......................................................................

Patch Set 4:

(1 comment)

File src/soc/intel/broadwell/gma.c:

https://review.coreboot.org/c/coreboot/+/48787/comment/865a714a_00cbf227 
PS2, Line 516: if (!acpi_is_wakeup_s3()) {
             : 		if (!CONFIG(CHROMEOS) || display_init_required())
> this should probably be something like: […]

I did this for patchset #4 together with dropping CHROMEOS test, there is already VBOOT test in display_init_required. With the OPROM information sounds like the delay needs to move just before run_bios(), going to try it with next pstchset and see what you think.

Can you check if ChromeOS repos have any .configs with PRE_GRAPHICS_DELAY!=0?