[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/common: Refactor S3 helpers

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )

Change subject: soc/amd/common: Refactor S3 helpers
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31490/5/src/soc/amd/common/block/pi/agesawra... 
File src/soc/amd/common/block/pi/agesawrapper.c:

https://review.coreboot.org/#/c/31490/5/src/soc/amd/common/block/pi/agesawra... 
PS5, Line 315: 	Status = OemS3Save(&RtbParams->S3DataBlock);
> I'd be reluctant to rely on AGESA_SUCCESS being 0 like that. […]

I believe most codes consider 0 as success, because it leaves a wide range for different errors. As fs for what I wrote, I was only explaining why that particular if form would work. That form was how original code has been written.
OTOH, as Marshall properly pointed out, the only reason a status is returned is for a common print if error, so I would be happy with a print after amd_dispatch.