23 Jun
2023
23 Jun
'23
7:21 a.m.
Attention is currently required from: Arthur Heymans, Arthur Heymans, Benjamin Doron, Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75886?usp=email )
Change subject: arch/x86,lib: Migrate SMBIOS implementation to common code ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75886/comment/ffec964b_01be6db8 : PS3, Line 11: code define
I think "having architecture-specific code define some functions" is equivalent to "requiring archit […]
I thought about it again. Let's leave it. Sorry for delaying.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75886?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I030c853f83f8427da4a4c661b82a6487938b24e6
Gerrit-Change-Number: 75886
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 22 Jun 2023 22:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-MessageType: comment