[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: add support to read SPD data from SMBus

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39401 )

Change subject: soc/intel/tigerlake: add support to read SPD data from SMBus
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39401/8/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit_jsl.c:

https://review.coreboot.org/c/coreboot/+/39401/8/src/soc/intel/tigerlake/mem... 
PS8, Line 121: 	meminit_channels(mem_cfg, board_cfg, spd_data_ptr, half_populated);
can't u just call
meminit_dq_dqs_map(mem_cfg, board_cfg, half_populated); 
from first if case? in that way u might not need to fill 0 into MemorySpdPtrxx UPDs which is default 0 by FSP?