Attention is currently required from: Tarun Tuli, Ravishankar Sarawadi, Kapil Porwal, Eric Lai, Uday Bhat.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72881 )
Change subject: mb/google/rex: Enable audio BT offload
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/72881/comment/007392c4_171affe0
PS8, Line 104: GPIO_PADBASED_OVERRIDE(padbased_table, i2s1_disable_pads);
i realized we do not need this. The i2s1 pins need to be disabled (in SSP1 mode) if originally configured as i2s1 native function . Here they are configured as DMIC and setting the pins as NC will break DMIC functionality.
i will push a change .
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46e9702add37464122ffc78826ebf8a6c5b5b07c
Gerrit-Change-Number: 72881
Gerrit-PatchSet: 8
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Uday M Bhat
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Comment-Date: Tue, 21 Mar 2023 03:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment