30 Jul
2020
30 Jul
'20
1:43 p.m.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41658 )
Change subject: nb/intel/haswell: Add Crystal Well PCI IDs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41658/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41658/1/src/northbridge/intel/haswe... PS1, Line 469: 0x0d00, 0x0d04, /* Crystal Well */
Can we add each on a separate line for consistency, please? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/41658
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfe55323fd06187148c788ebfa7b679b6944e4f3
Gerrit-Change-Number: 41658
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Jul 2020 16:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment