[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )

Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................

Patch Set 7:
> Patch Set 7:
> > Patch Set 7:
> > > Patch Set 7:
> > > > Patch Set 7:
> > > > > Patch Set 7: Code-Review-2
> > > > >
> > > > > (1 comment)
> > > > >
> > > > > select C_ENVIRONMENT_BOOTBLOCK is the braswell Kconfig and drop the romcc bootblock option and add console init in the bootblock.
> > > > > Also drop things that get unused in drivers/intel/fsp1_1
> > > > > This patch is not even build tested...
> > > >
> > > > This patch is to support C_ENVIRONMENT_BOOTBLOCK for Braswell. To be backward compatible this support has made optional.
> > >
> > > Please don't make it optional and remove the 'backwards compatibility', there is really no reason to keep that around.
> > > > This patch has been build and tested. I will check if I made mistake by uploading.
> > >
> > > No gerrit has not build-tested it.
> > > > Can you clarify your comment?
> >
> > I concur with Arthur. C_ENVIRONMENT_BOOTBLOCK is becoming a standard in coreboot. No reason to keep backward compatibility.
>
> Removing backward compatibity in Braswell is no problem. Removing it from drivers/intel/fsp1_1 means also Intel Quark backward compatibility will be removed. I can verify that Intel Quark still build, but how to be sure tree is still working fine?

The quark fsp1.1 option was dropped in master so no need to worry about that.