19 Feb
2019
19 Feb
'19
5:57 a.m.
Łukasz Siudut has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31435 )
Change subject: mb/ocp/monolake: fix for booting issues + tmp and ipmi support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31435/1/src/mainboard/ocp/monolake/Kconfig File src/mainboard/ocp/monolake/Kconfig:
https://review.coreboot.org/#/c/31435/1/src/mainboard/ocp/monolake/Kconfig@1... PS1, Line 15: select MAINBOARD_HAS_TPM1
why not select the superio, too ? […]
Regarding SUPERIO_ITE_IT8528E - I didn't select it deliberately as I'm not certain if the server even have the chip :).
--
To view, visit https://review.coreboot.org/c/coreboot/+/31435
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbe9d19c7413098c56d1b6131640097fdf731ab
Gerrit-Change-Number: 31435
Gerrit-PatchSet: 1
Gerrit-Owner: Łukasz Siudut
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 19 Feb 2019 08:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-MessageType: comment