HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31004 )
Change subject: mb/(ICH7): Do not try to rewrite on V1CAP register
......................................................................
Patch Set 2:
(1 comment)
Do you know people with these devices, willing to test? Maybe ask
in #libreboot?
those R/WO register is linked to ICH7. As we already did the write on early_init.c , the 2nd write have no effect.
this is tested on Nec board I have.
I've checked if we can rewrite something using printk before and after. I can say that this register is R/WO ;)
this said, the 2nd write is the same as the 1st one on "early_init.c", so no harm ... but I think it is better to drop the 2nd write
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4469cb7505d584f10c98aec579a2d78bf1950bf3
Gerrit-Change-Number: 31004
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Jan 2019 16:23:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment