Attention is currently required from: Damien Zammit, Michał Żygowski, Michał Kopeć, Michael Niewöhner, Piotr Król, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63672 )
Change subject: superio/ite/common: Add support for SuperIOs with 6 temperature reading registers ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63672/comment/74ff60ab_a5cb07ff PS1, Line 14: Additionally, decouple temperature offset/min/max configuration from TMPIN : mode configuration, since in these SIOs, TMPINs do not have to map directly : to temperature reading registers (e.g. TMPIN1 can read to temperature reading : register 3). Can you put that into a separate commit?
https://review.coreboot.org/c/coreboot/+/63672/comment/6a70d3e1_c82771e1 PS1, Line 19: Add a Kconfig option SUPERIO_ITE_ENV_CTRL_6_TEMPS for these ECs. Is there no way to determin the number of registers at run-time?
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/63672/comment/ee77d6d9_83b5bfd6 PS1, Line 125: int bool?
https://review.coreboot.org/c/coreboot/+/63672/comment/e45e625f_206a6d27 PS1, Line 127: if (source >= THERMAL_SOURCE_PECI1 && source <= THERMAL_SOURCE_PECI5) : return 1; : : return 0; Something like:
return (source >= THERMAL_SOURCE_PECI1 && source <= THERMAL_SOURCE_PECI5)