Attention is currently required from: Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60232 )
Change subject: cbfstool: Avoid defining _XOPEN_SOURCE on macOS ......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60232/comment/ff52145d_e01fa0a5 PS1, Line 137: ifneq ($(OS_ARCH),$(filter $(OS_ARCH), Darwin FreeBSD)) This file can be included by either util/cbfstool/Makefile or the toplevel coreboot Makefile.inc, so you can't just rely on things only set in the former here. I'd suggest to just leave the shell expand where it is.