18 Dec
2019
18 Dec
'19
5:42 p.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37815 )
Change subject: src/*.asl: Add FIXME comments ......................................................................
Patch Set 2:
Patch Set 2:
I'm a little confused by this change. Aren't the non-mainboard changes already on master from CB:36318? I don't see any benefit in having the not-for-merge be its parent. If you rebase on master, do most of the files' changes go away.
reverted here: https://review.coreboot.org/c/coreboot/+/37710
--
To view, visit https://review.coreboot.org/c/coreboot/+/37815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12acd54679c2c712d5f2a9dce5fb28f4c966eb2b
Gerrit-Change-Number: 37815
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Dec 2019 16:42:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment