Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )
Change subject: mb/ocp/deltalake: Set coreboot log level via VPD variable
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45134/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45134/1/src/mainboard/ocp/deltalake...
PS1, Line 4: bootblock-$(CONFIG_CONSOLE_OVERRIDE_LOGLEVEL) += loglevel.c
Instead of adding four lines, use `all`:
all-$(CONFIG_CONSOLE_OVERRIDE_LOGLEVEL) += loglevel.c
https://review.coreboot.org/c/coreboot/+/45134/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/loglevel.c:
https://review.coreboot.org/c/coreboot/+/45134/1/src/mainboard/ocp/deltalake...
PS1, Line 16: val > 8
val >= BIOS_NEVER
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4
Gerrit-Change-Number: 45134
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-Comment-Date: Mon, 07 Sep 2020 10:01:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment