Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33787 )
Change subject: libpayload/libc: Correct strlcat return value
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33787/1/payloads/libpayload/libc/string.c
File payloads/libpayload/libc/string.c:
https://review.coreboot.org/#/c/33787/1/payloads/libpayload/libc/string.c@26...
PS1, Line 267: return sl + dl;
Sorry, I should have been more clear. […]
Oh, looks like I just totally misunderstood the man page. Sorry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4421305af85bce88d12d6fdc2eea6807ccdcf449
Gerrit-Change-Number: 33787
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 25 Jun 2019 20:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment