Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60148 )
Change subject: mb/google/reef: Move selects from Kconfig.name to Kconfig ......................................................................
mb/google/reef: Move selects from Kconfig.name to Kconfig
Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files.
Change-Id: Id71c63556da73a09c5a6d3e844686ddc3e113ea7 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60148 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/reef/Kconfig M src/mainboard/google/reef/Kconfig.name 2 files changed, 24 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index b0dce19..a4bd882 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -22,6 +22,30 @@ select SOC_INTEL_APOLLOLAKE select USE_SAR
+config BOARD_GOOGLE_REEF + select BASEBOARD_REEF_LAPTOP + select BOARD_GOOGLE_BASEBOARD_REEF + +config BOARD_GOOGLE_PYRO + select BASEBOARD_REEF_LAPTOP + select BOARD_GOOGLE_BASEBOARD_REEF + +config BOARD_GOOGLE_SAND + select BASEBOARD_REEF_LAPTOP + select BOARD_GOOGLE_BASEBOARD_REEF + +config BOARD_GOOGLE_SNAPPY + select BASEBOARD_REEF_LAPTOP + select BOARD_GOOGLE_BASEBOARD_REEF + +config BOARD_GOOGLE_NASHER + select BASEBOARD_REEF_LAPTOP + select BOARD_GOOGLE_BASEBOARD_REEF + +config BOARD_GOOGLE_CORAL + select BASEBOARD_REEF_LAPTOP + select BOARD_GOOGLE_BASEBOARD_REEF + if BOARD_GOOGLE_BASEBOARD_REEF
config BASEBOARD_REEF_LAPTOP diff --git a/src/mainboard/google/reef/Kconfig.name b/src/mainboard/google/reef/Kconfig.name index a3ca6f4..2b33741 100644 --- a/src/mainboard/google/reef/Kconfig.name +++ b/src/mainboard/google/reef/Kconfig.name @@ -2,30 +2,18 @@
config BOARD_GOOGLE_REEF bool "-> Reef/Electro (Acer Chromebook Spin 11 R751T)" - select BASEBOARD_REEF_LAPTOP - select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_PYRO bool "-> Pyro (Lenovo Thinkpad (Yoga) 11e Chromebook)" - select BASEBOARD_REEF_LAPTOP - select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_SAND bool "-> Sand (Acer Chromebook 15 CB515-1HT/1H)" - select BASEBOARD_REEF_LAPTOP - select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_SNAPPY bool "-> Snappy (HP Chromebook x360 11 G1 EE)" - select BASEBOARD_REEF_LAPTOP - select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_NASHER bool "-> Nasher" - select BASEBOARD_REEF_LAPTOP - select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_CORAL bool "-> Coral" - select BASEBOARD_REEF_LAPTOP - select BOARD_GOOGLE_BASEBOARD_REEF