Attention is currently required from: Gavin Liu, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/blobs/+/86382?usp=email )
Change subject: soc/mediatek/mt8196: Add libbl31.a version v1.0 ......................................................................
Patch Set 2:
(11 comments)
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/86382/comment/e04b97a5_1eb63776?usp=em... : PS2, Line 287: Mediatek MediaTek
https://review.coreboot.org/c/blobs/+/86382/comment/19405e11_e6afd877?usp=em... : PS2, Line 293: mminfra Uppercase
https://review.coreboot.org/c/blobs/+/86382/comment/366a140e_70294293?usp=em... : PS2, Line 294: smmu_sid Should this be uppercase as well (something like `SMMU SID`)?
https://review.coreboot.org/c/blobs/+/86382/comment/7b8b59c7_ced425dc?usp=em... : PS2, Line 296: use uses
https://review.coreboot.org/c/blobs/+/86382/comment/cc64097e_44305423?usp=em... : PS2, Line 297: ARM-Trusted-Firmware links `libbl31.a` when building `bl31.elf`. ``` By specifying the `MTKLIB_PATH=libbl31.a` make variable when building BL31, the library will be linked with `bl31.elf`. ```
https://review.coreboot.org/c/blobs/+/86382/comment/d676ccb2_63c6df60?usp=em... : PS2, Line 298: Missing `## Version` section, which is a requirement for all upstream blobs.
File soc/mediatek/mt8196/libbl31.a:
PS2: Fix executable file mode.
File soc/mediatek/mt8196/libbl31.a.md5:
https://review.coreboot.org/c/blobs/+/86382/comment/f7db1869_ed6e557e?usp=em... : PS2, Line 2: extra blank line
File soc/mediatek/mt8196/libbl31_release_note.txt:
https://review.coreboot.org/c/blobs/+/86382/comment/eeb5f777_1ce290a4?usp=em... : PS2, Line 1: 1.0 Can we use the latest version 16174.X.0 from FW branch?
https://review.coreboot.org/c/blobs/+/86382/comment/5f717714_5e399c5c?usp=em... : PS2, Line 5: Include Included
https://review.coreboot.org/c/blobs/+/86382/comment/b1dd9c4d_7d8261a1?usp=em... : PS2, Line 7: - CL:*8004008 feat(mt8196): add MT8196 UFS driver Sort from latest to the oldest (just like git log output)?