Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/...
File src/mainboard/amd/padmelon/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/...
PS2, Line 65: device pnp 4e.4 off end # HWM
enable this device and set io base address and irq here
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/...
File src/mainboard/amd/padmelon/fan_init.c:
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/...
PS2, Line 115: fintek_enable_device(F81803A_HWM, 0x0220, 0xff);
this should be done via the corresponding devicetree entries and not manually
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a366ddeb4cfebd177a8744f6edb87aecd4787dd
Gerrit-Change-Number: 33993
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jul 2019 19:41:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment