mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44868 )
Change subject: trogdor: report hardware watchdog reset after reboot ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
(1 comment)
You should probably reorder this patch towards the back of the train so that we can start landing other patches while this is still being discussed.
This patch will be moved to back of train until ready with +2
https://review.coreboot.org/c/coreboot/+/44868/1/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/44868/1/src/soc/qualcomm/sc7180/soc... PS1, Line 27: volatile unsigned int aoss = *(unsigned int *)AOSS_CC_RESET_STATUS;
Guys, how many drivers have we landed by now? You *know* this is not how to do register accesses in […]
This was put in place by Ravi and T.mike who are not driver developers as a quick test. Ravi will follow the correct procedure
https://review.coreboot.org/c/coreboot/+/44868/1/src/soc/qualcomm/sc7180/soc... PS1, Line 30: printk(BIOS_INFO, "AOSS_CC_RESET_STATUS[%x]..[%x]\n", AOSS_CC_RESET_STATUS, aoss);
This doesn't work for me -- even if the reboot was a watchdog, the register seems to contain a 0. […]
Kernel needs to be up to date and built without KGDB option, and we have seen this working.