Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42643 )
Change subject: sb/intel/i82801jx/sata.c: Handle ABAR as a resource
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42643/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42643/3//COMMIT_MSG@10
PS3, Line 10: and treat it as a resource. This prevents problems if ABAR is not set.
What kind of problems? ;-)
No idea. Most likely undefined behavior, but I haven't tried.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f888b748204860b0a7e1bf5611f5f3e487e8081
Gerrit-Change-Number: 42643
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 13:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment