Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32778 )
Change subject: libpayload: ahci: Prevent memory leaks when failing on init ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32778/2/payloads/libpayload/drivers/storage/... File payloads/libpayload/drivers/storage/ahci.c:
https://review.coreboot.org/#/c/32778/2/payloads/libpayload/drivers/storage/... PS2, Line 111: /* Set command list base and received FIS base. */ This comment applies more to the part of the block that wasn't moved.
https://review.coreboot.org/#/c/32778/2/payloads/libpayload/drivers/storage/... PS2, Line 183: * still use the resources for DMA. */ Please use one of the commenting styles documented here: https://doc.coreboot.org/coding_style.html#commenting e.g. drop the asterisk on the left