Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27542 )
Change subject: mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2# ......................................................................
Patch Set 1:
(1 comment)
Can you please upload this change to poppy branch as well?
https://review.coreboot.org/#/c/27542/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nautilus/gpio.c:
https://review.coreboot.org/#/c/27542/1/src/mainboard/google/poppy/variants/... PS1, Line 223: OC0 and OC1 also don't have external pulls. Don't you need internal pulls on those lines?