Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41832 )
Change subject: uti/cbfstool: Add option --pow2page ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41832/2/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/41832/2/util/cbfstool/cbfstool.c@12... PS2, Line 1294: LONGOPT_START = 256, is this ascii with parity bit? ^^
https://review.coreboot.org/c/coreboot/+/41832/2/util/cbfstool/cbfstool.c@14... PS2, Line 1422: " [-a alignment] [-y|--xip] [-P page-size] [-Q] [--ibb] " There seems to be nothing in the help text that tells us what it is. Do we really need a single-letter option at all? A `--pow2page` here would at least give a hint what it is about.