Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63592 )
Change subject: mb/google/nipperkin: Disable PSPP for WLAN ......................................................................
mb/google/nipperkin: Disable PSPP for WLAN
Disable PSPP parameters for WLAN card on Nipperkin. This feature is causing S0ix resume hangs.
BUG=b:227296841,b:228830362 BRANCH=guybrush TEST=Suspend stress test passes on Nipperkin
Change-Id: I19d3a11c251f8dc9ecca6a087adeef28dcda7ec0 Signed-off-by: Rob Barnes robbarnes@google.com --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/libgfxinit M 3rdparty/libhwbase M src/mainboard/google/guybrush/variants/nipperkin/variant.c 6 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/63592/1
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index a069321..c3aa07a 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit a0693217d2fea9f3c05f6d96008c1ad301ed69e6 +Subproject commit c3aa07acc64a95c46d17799f4062f98acf40989d diff --git a/3rdparty/blobs b/3rdparty/blobs index 8c580e5..2c67522 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 8c580e55da92252fa665b5038b87100d0e076d23 +Subproject commit 2c67522aae7132c337d994e0ed48ba6d182df08a diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 115c3e4..ee319ae 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 115c3e4cdad6a9d84bf06e066162c5c546a9d2c3 +Subproject commit ee319ae7bc59e88b60142f40a9ec1b46656de4db diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 1b04c51..f64ccae 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 1b04c517b377468b3b470d38607fb539187391dd +Subproject commit f64ccae3ba02210a6f4309264d8e5b8e1af636a8 diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase index fc2102f..9946827 160000 --- a/3rdparty/libhwbase +++ b/3rdparty/libhwbase @@ -1 +1 @@ -Subproject commit fc2102f560f25e0f2e5be91ec36646dcb69e6e1b +Subproject commit 9946827bbae199477cfcb68dcc5ed257aaa9ba7d diff --git a/src/mainboard/google/guybrush/variants/nipperkin/variant.c b/src/mainboard/google/guybrush/variants/nipperkin/variant.c index 204ec61..b10aadf 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/variant.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/variant.c @@ -4,6 +4,7 @@ #include <boardid.h> #include <device/device.h> #include <soc/gpio.h> +#include <string.h>
void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors) { @@ -12,6 +13,9 @@ if (board_version >= 3) { dxio_descriptors[WLAN].link_aspm_L1_1 = true; dxio_descriptors[WLAN].link_aspm_L1_2 = true; + /* Disable PSPP */ + memset(dxio_descriptors[WLAN].port_params, 0, + sizeof(dxio_descriptors[WLAN].port_params)); } else { dxio_descriptors[WLAN].link_aspm_L1_1 = false; dxio_descriptors[WLAN].link_aspm_L1_2 = false;