Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kyösti Mälkki, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50373 )
Change subject: soc/amd/common/gpio: add PAD_NF_SCI pad type ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50373/comment/f96fae59_99ff87fa PS2, Line 7: PAD_NF_SCI Note to self: Even if a pad is configured using PAD_NF_SCI, `set_single_gpio()` would complain about missing GEVENT if the pad does not support SCI mapping.
One more thing to remember is that `soc_get_gpio_event_table()` expects a mapping of pad->GEVENT irrespective of IOMUX setting i.e. the GEVENT could be associated with either NF or GPIO functions depending upon what the platform really supports. Probably at some point we might want to think about ensuring that the SCI routing is enabled only for the expected function (i.e. NF or GPIO depending upon what the platform supports) for every pad.