Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44716 )
Change subject: soc/mediatek/mt8192: Do dramc command bus training
......................................................................
Patch Set 46:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44716/46//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44716/46//COMMIT_MSG@8
PS46, Line 8:
1. Please describe the implementation, and mention the datasheet name and revision. The term FSP(1) shows up a lot.
2. How is this tested?
https://review.coreboot.org/c/coreboot/+/44716/46/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44716/46/src/soc/mediatek/mt8192/dr...
PS46, Line 1278:
Please remove the blank line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06ee26e3b82811bffa09ab5e3e535b3174c3e3a6
Gerrit-Change-Number: 44716
Gerrit-PatchSet: 46
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Jan 2021 08:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment