Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47442 )
Change subject: vc/google/chromeos/sar: Make "SAR not found" log a debug message
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47442/4/src/vendorcode/google/chrom...
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/47442/4/src/vendorcode/google/chrom...
PS4, Line 71: /* Try to read the SAR limit entry from VPD */
Not for this change, but I think we should drop the support for SAR in VPD completely. This is not really recommended for any new platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c122a57cfe92b27e0291933618ca13d8e1889ba
Gerrit-Change-Number: 47442
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 18:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment