Po Xu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )
Change subject: soc/mediatek: Move auxadc driver from MT8183 to common ......................................................................
Patch Set 25: Code-Review+1
Patch Set 24:
also, I saw build failure:
src/mainboard/google/kukui/boardid.c:72:14: error: implicit declaration of function 'auxadc_get_voltage'; did you mean 'auxadc_get_voltage_uv'? [-Werror=implicit-function-declaration] int value = auxadc_get_voltage(channel); ^~~~~~~~~~~~~~~~~~ auxadc_get_voltage_uv
Because now the api name of auxadc has been changed a bit ( comment: Paul Menzel Oct 16 Please add the unit to the function name:`auxadc_get_voltage_uv()`.), The caller still uses the original api, so it will cause build fail. We will continue to fix this fail later