Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37044 )
Change subject: drivers/spi/boot_device_rw_nommap.c: Drop CAR_GLOBAL_MIGRATION support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37044/7/src/drivers/spi/boot_device...
File src/drivers/spi/boot_device_rw_nommap.c:
https://review.coreboot.org/c/coreboot/+/37044/7/src/drivers/spi/boot_device...
PS7, Line 28: if (sf == NULL)
again, should this null check be kept? (same for the others)
To me it appeared sfg_init_done acts as the guard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I613c28a2d06f5f0216deb75960ab660941ef8057
Gerrit-Change-Number: 37044
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 09:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment