[coreboot-gerrit] Change in coreboot[master]: coreboot-id: Add coreboot id based on FMAP entries

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )

Change subject: coreboot-id: Add coreboot id based on FMAP entries
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... 
File src/mainboard/siemens/mc_apl1/mc_apl_vboot.fmd:

https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... 
PS2, Line 9: COREBOOT_ID 0x40
           : 			RO_FRID_PAD 0x780
> In fact I bet the main reason Furquan is excluding CONFIG_CHROMEOS from this is to avoid having to update a hundred FMAPs of old Chrome OS boards, which leads us to the weird inconsistency where some configurations will have this ID and some won't (which I think is a bad idea... if we want to have this ID, it should be consistent everywhere, otherwise it's pretty useless).

Actually, no. The reason I dropped it from Chrome OS boards is because I am confident that we don't use it and we have RO_FRID which already stores similar information. I can add it back if you want all boards to be consistent. But, I don't think it really adds more value to Chrome OS boards where we already have RO_FRID.