Erin Lo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Makefile....
File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Makefile....
PS4, Line 32: sspm-compression := $(CBFS_COMPRESS_FLAG)
Odd that you said you weren't compressing it anymore now? Because this definitely looks like you do […]
Sorry, I didn't recognize it compressed or not decided here.
Do you mean you suggest keep it in compressed? And then we can't use cbfs_boot_map_with_leak()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31516
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ae6034454326f5115cd3948819adc448b67fb1c
Gerrit-Change-Number: 31516
Gerrit-PatchSet: 4
Gerrit-Owner: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Erin Lo
erin.lo@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Comment-Date: Wed, 06 Mar 2019 02:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
