6 Dec
2019
6 Dec
'19
3:40 p.m.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37533 )
Change subject: Revert commit bfb5c807e720761f4457d5106bb919f2aacb5535 binaryPI: Drop PSP Secure OS from build ......................................................................
Patch Set 1:
I agree with finding exactly which files are needed. I really doubt it will be the SecureOs, PspTrustlets, or TrustletKey files. See soc/amd/stoneyridge/Makefile.inc and Kconfig for how the Secure OS was removed.
I think a better approach is to make it a config option like in stoneyridge. And maybe default it to n if you find those files aren't necessary on Bettong. (I infer you have a Merlin Falcon on yours and not a Prairie Falcon, BTW.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/37533
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I903824019ebbe7934dbe12297b3a223cab3461c5
Gerrit-Change-Number: 37533
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002701
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002701
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Dec 2019 15:40:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment